linux-kernel - Re: [PATCH] unbreak automount daemon after fixing autofs5 ABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F99082F.1040902@msgid.tls.msk.ru>
Date:	Thu, 26 Apr 2012 12:32:47 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Ian Kent <raven@...maw.net>
CC:	Linux-kernel <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Meyer <thomas@...3r.de>, stable@...nel.org,
	autofs@...r.kernel.org
Subject: Re: [PATCH] unbreak automount daemon after fixing autofs5 ABI

On 26.04.2012 12:21, Ian Kent wrote:
> On Thu, 2012-04-26 at 10:26 +0400, Michael Tokarev wrote:
[]
>> Change 499f286dc02cde6b tries to fix the original interface
>> bug for 32bit userspace running on 64bit kernel.  But the
>> issue is that autofs5 already has a workaround for it, so
>> the end result is that the two (kernel & user) disagree
>> again.  "Fix" this by applying the in-kernel fix only if
>> the process is not named "automount" -- which is how autofs5
>> daemon is named.
> 
> No, you cannot be sure the autofs binary is named automount.

Well, I checked several distributions, all have the binary named
this way.  Yes a user can rename it and it will break again, but
it is at least better than now when it does not work at all.  And
yes it is messy, just like current situation already is.

> Not only that, this approach makes an unpleasant change even more
> unpleasant.
> 
> I still think that my original proposed patches were the better approach
> to handling this problem.
> 
> My recommendation was that the major autofs kernel protocol version be
> bumped and a packed structure used from that version on. That allows
> user space to request that protocol version for communication at mount
> time. If systemd doesn't want to support earlier protocol versions then
> it can complain, instructing the user to update to a later kernel.

This is exactly what I was proposing when I started my thread about
3.0.24 autofs breakage -- to _revert_ the in-kernel fix and introduce
a new interface (or variation thereof, in means of a new mount option
or something).  This way, breakage and mess are both minimal.

Note that a major protocol changes aren't really needed, just a single
mount option, which uses a right size of the structure.  Unless at the
same time you want to change something else.

> I understand why that proposal was not well accepted but the fact

But I don't understand this ;)

> remains, I did make a mistake and I did chose to work around it in user
> space rather than cope with the pain at the time. In hind site that may
> have been the wrong thing to do but that's history. So I believe the
> most sensible thing to do now is to take the approach that minimizes
> breakage.

No one complains to you now about the history, and it is not relevant
now already, as we do have what we have.

And yes I 100% agree that reverting that "fix" change in kernel and
introducing a more sane "slightly new" interface is the way to go.

Thank you!

/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/