linux-kernel - Re: [PATCH 1/4] mfd: add LM3533 lighting-power core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120426124122.GA26692@sirena.org.uk>
Date:	Thu, 26 Apr 2012 13:41:23 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Johan Hovold <jhovold@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH 1/4] mfd: add LM3533 lighting-power core driver

On Fri, Apr 20, 2012 at 05:30:23PM +0200, Johan Hovold wrote:

> +static int __lm3533_read(struct lm3533 *lm3533, u8 reg, u8 *val)
> +{
> +	int ret;
> +
> +	ret = lm3533->read(lm3533, reg, val);
> +	if (ret < 0) {

Looks like you could save a bunch of code by using regmap for the
register I/O.  This would also give you access to the cache and
diagnostic infrastructure it has.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/