linux-kernel - Re: c/r: prctl: Drop VMA flags test on PR_SET_MM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5j++rdN3yi4cRHiWcRTuzRYSbQyRHY5ZOrjGT=p2VG5ijA@mail.gmail.com>
Date:	Thu, 26 Apr 2012 11:17:08 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: c/r: prctl: Drop VMA flags test on PR_SET_MM_ stack data assignment

On Thu, Apr 26, 2012 at 9:08 AM, Cyrill Gorcunov <gorcunov@...il.com> wrote:
> From: Cyrill Gorcunov <gorcunov@...nvz.org>
>
> With the
>
>  | commit b76437579d1344b612cf1851ae610c636cec7db0
>  | Author: Siddhesh Poyarekar <siddhesh.poyarekar@...il.com>
>  | Date:   Wed Mar 21 16:34:04 2012 -0700
>  |
>  | procfs: mark thread stack correctly in proc/<pid>/maps
>
> the stack allocated via clone() is marked in /proc/<pid>/maps as
> [stack:%d] thus it might be out of the former mm->start_stack/end_stack
> values (and even has some custom VMA flags set). So to be able to
> restore mm->start_stack/end_stack drop vma flags test, but still
> require the undrlied VMA to exist.
>
> As always note this feature is under CONFIG_CHECKPOINT_RESTORE
> and requires CAP_SYS_RESOURCE to be granted.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>

It'd be nice if there was some sensible per-thread kernel record of
where the stack is expected to be. Regardless:

Acked-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/