linux-kernel - Re: [PATCH] pinctrl: enhance reporting of errors when loading from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYXtPKQz2hKkm4C=b5N8Dg4ioH94T-QQLorVFPmF8sRZw@mail.gmail.com>
Date:	Thu, 26 Apr 2012 23:12:30 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	John Crispin <blogic@...nwrt.org>
Cc:	Stephen Warren <swarren@...dia.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: enhance reporting of errors when loading from DT

On Thu, Apr 26, 2012 at 4:47 PM, John Crispin <blogic@...nwrt.org> wrote:

> There are a few places in the api where the code simply returns -EINVAL when
> it finds an error. An example is pinmux_map_to_setting() which now reports an
> error if we try to match a group with a function that it does not support.
>
> The reporting of errors in pinconf_check_ops and pinmux_check_ops now has the
> same style and is located inside the according functions and not the calling
> code.
>
> When the map is found in the DT but the default state can not be selected we
> get an error to know that the code at least tried.
>
> The patch also removes a stray word from one comment and a "->" from another
> for the sake of consistency.
>
> Finally we replace a few pr_err/debug() calls with dev_err/dbg().
>
> Thanks go to Stephen Warren for reviewing the patch and enhancing the reporting
> inside pinmux_map_to_setting().
>
> Signed-off-by: John Crispin <blogic@...nwrt.org>
> Cc: Stephen Warren <swarren@...dia.com>
> Cc: linux-kernel@...r.kernel.org

Thanks, applied with Stephens ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/