linux-kernel - Re: [PATCH v2] leds: add new transient trigger for one shot timer activation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120426160227.214fcb17@notabene.brown>
Date:	Thu, 26 Apr 2012 16:02:27 +1000
From:	NeilBrown <neilb@...e.de>
To:	shuahkhan@...il.com
Cc:	akpm@...ux-foundation.org, Jonas Bonn <jonas@...thpole.se>,
	LKML <linux-kernel@...r.kernel.org>,
	Richard Purdie <richard.purdie@...uxfoundation.org>
Subject: Re: [PATCH  v2] leds: add new transient trigger for one shot timer
 activation

On Wed, 25 Apr 2012 11:42:38 -0600 Shuah Khan <shuahkhan@...il.com> wrote:

> There was a suggestion to change units to seconds similar to "safe_delay_show" 
> and "safe_delay_store" in drivers/md/md.c. safe_delay_show shows time in
> seconds, however safe_delay_store still takes the value in msecs. This
> sounded like an asymmetric interface.

I don't think you read the code properly.  "strict_strtoul_scaled" takes
a number like "0.20" and scales it to an integer...
(though your decision not to take that approach may still be justified).

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)