linux-kernel - Re: [PATCH next 00/12] mm: replace struct mem_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F9A4E8E.4040700@openvz.org>
Date:	Fri, 27 Apr 2012 11:45:18 +0400
From:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH next 00/12] mm: replace struct mem_cgroup_zone with struct
 lruvec

Andrew Morton wrote:
> On Thu, 26 Apr 2012 11:53:44 +0400
> Konstantin Khlebnikov<khlebnikov@...nvz.org>  wrote:
>
>> This patchset depends on Johannes Weiner's patch
>> "mm: memcg: count pte references from every member of the reclaimed hierarchy".
>>
>> bloat-o-meter delta for patches 2..12
>>
>> add/remove: 6/6 grow/shrink: 6/14 up/down: 4414/-4625 (-211)
>
> That's the sole effect and intent of the patchset?  To save 211 bytes?

This is almost last bunch of cleanups for lru_lock splitting,
code reducing is only nice side-effect.
Also this patchset removes many redundant lruvec relookups.

Now mostly all page-to-lruvec translations are located at the same level
as zone->lru_lock locking. So lru-lock splitting patchset can something like this:

-zone = page_zone(page)
-spin_lock_irq(&zone->lru_lock)
-lruvec = mem_cgroup_page_lruvec(page)
+lruvec = lock_page_lruvec_irq(page)

>
>> ...
>>
>>   include/linux/memcontrol.h |   16 +--
>>   include/linux/mmzone.h     |   14 ++
>>   mm/memcontrol.c            |   33 +++--
>>   mm/mmzone.c                |   14 ++
>>   mm/page_alloc.c            |    8 -
>>   mm/vmscan.c                |  277 ++++++++++++++++++++------------------------
>>   6 files changed, 177 insertions(+), 185 deletions(-)
>
> If so, I'm not sure that it is worth the risk and effort?

After lumpy-reclaim removal there a lot of dead or redundant code, maybe someone else
wants to cleanup this code, I specifically sent this set early to avoid conflicts.

>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email:<a href=mailto:"dont@...ck.org">  email@...ck.org</a>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/