linux-kernel - Re: [ 43/62] usb: gadget: udc-core: fix asymmetric calls in remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120427080046.GD3411@arwen.pp.htv.fi>
Date:	Fri, 27 Apr 2012 11:00:47 +0300
From:	Felipe Balbi <balbi@...com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Ben Hutchings <ben@...adent.org.uk>,
	Kishon Vijay Abraham I <kishon@...com>,
	Felipe Balbi <balbi@...com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Partha Basak <p-basak2@...com>
Subject: Re: [ 43/62] usb: gadget: udc-core: fix asymmetric calls in
 remove_driver

On Thu, Apr 26, 2012 at 02:16:32PM -0700, Greg KH wrote:
> On Thu, Apr 26, 2012 at 01:34:35AM +0100, Ben Hutchings wrote:
> > On Tue, Apr 24, 2012 at 03:33:24PM -0700, Greg KH wrote:
> > > 3.3-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Kishon Vijay Abraham I <kishon@...com>
> > > 
> > > commit 8ae8090c82eb407267001f75b3d256b3bd4ae691 upstream.
> > > 
> > > During modprobe of gadget driver, pullup is called after
> > > udc_start. In order to make the exit path symmetric when
> > > removing a gadget driver, call pullup before ->udc_stop.
> > [...]
> >  
> > It looks like commit 6d258a4c42089229b855fd706622029decf316d6
> > (previous patch in this series!) added another case where the
> > cleanup functions are called in the wrong order.
> 
> Felipe?  Any thoughts?

oops, indeed. Will send a fix ASAP. Thanks for spotting that one.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)