| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120427082930.GC826@shlinux2.ap.freescale.net> Date: Fri, 27 Apr 2012 16:29:31 +0800 From: Dong Aisheng <aisheng.dong@...escale.com> To: Sascha Hauer <s.hauer@...gutronix.de> CC: Dong Aisheng-B29396 <B29396@...escale.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree-discuss@...ts.ozlabs.org" <devicetree-discuss@...ts.ozlabs.org>, "linus.walleij@...ricsson.com" <linus.walleij@...ricsson.com>, "swarren@...dotorg.org" <swarren@...dotorg.org>, Guo Shawn-R65073 <r65073@...escale.com>, "kernel@...gutronix.de" <kernel@...gutronix.de>, "grant.likely@...retlab.ca" <grant.likely@...retlab.ca>, "rob.herring@...xeda.com" <rob.herring@...xeda.com>, "cjb@...top.org" <cjb@...top.org>, Zhao Richard-B20223 <B20223@...escale.com> Subject: Re: [PATCH v3 4/4] mmc: sdhci-imx-esdhc: convert to use pinctrl subsystem On Fri, Apr 27, 2012 at 03:35:04PM +0800, Sascha Hauer wrote: > On Thu, Apr 26, 2012 at 10:40:27PM +0800, Dong Aisheng wrote: > > From: Dong Aisheng <dong.aisheng@...aro.org> > > > > This driver is shared between many platforms. Currently only imx6q has > > pinctrl support, to avoid breaking other platforms that do not have pinctrl > > support to run this driver, enable pinctrl dummy state for them before > > they also convert to pinctrl subsystem. > > > > Signed-off-by: Dong Aisheng <dong.aisheng@...aro.org> > > --- > > This patch depends on: > > pinctrl: add pinctrl_provide_dummies interface for platforms to use > > http://www.spinics.net/lists/arm-kernel/msg171538.html > > > > ChangeLog v2->v3: > > * patch name updated. > > v1 name is ARM: imx6q: switch to use pinctrl driver > > * using pinctrl dummy state to avoid breaking other platforms to use this > > driver. > > > > ChangeLog v1->v2: > > * using updated binding > > --- > > arch/arm/boot/dts/imx6q-arm2.dts | 4 +++ > > arch/arm/boot/dts/imx6q.dtsi | 32 ++++++++++++++++++++++++ > > arch/arm/mach-imx/Kconfig | 2 + > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c | 2 + > > arch/arm/mach-imx/mach-cpuimx51.c | 2 + > > arch/arm/mach-imx/mach-cpuimx51sd.c | 2 + > > arch/arm/mach-imx/mach-eukrea_cpuimx25.c | 2 + > > arch/arm/mach-imx/mach-mx25_3ds.c | 2 + > > arch/arm/mach-imx/mach-mx35_3ds.c | 2 + > > arch/arm/mach-imx/mach-mx51_3ds.c | 2 + > > arch/arm/mach-imx/mach-mx51_babbage.c | 2 + > > arch/arm/mach-imx/mach-mx51_efikamx.c | 2 + > > arch/arm/mach-imx/mach-mx51_efikasb.c | 2 + > > arch/arm/mach-imx/mach-mx53_ard.c | 2 + > > arch/arm/mach-imx/mach-mx53_evk.c | 2 + > > arch/arm/mach-imx/mach-mx53_loco.c | 2 + > > arch/arm/mach-imx/mach-mx53_smd.c | 2 + > > arch/arm/mach-imx/mach-pcm043.c | 2 + > > arch/arm/mach-imx/mach-vpr200.c | 2 + > > Here you are patching only the boards which happen to use the esdhc > controller, so we need to patch other boards when another driver gains Yes, theoretically, if a board does not have drivers running with pinctrl, it may not need change. There're so many boards under arch/arm/mach-imx/*: b29396@...inux2:~/upstream/linux-pinctrl$ ls arch/arm/mach-imx/mach- mach-apf9328.c mach-imx27_visstrim_m10.c mach-mx31lilly.c mach-mx51_efikamx.o mach-pcm037_eet.c mach-armadillo5x0.c mach-imx6q.c mach-mx31lilly.o mach-mx51_efikasb.c mach-pcm037_eet.o mach-armadillo5x0.o mach-imx6q.o mach-mx31lite.c mach-mx51_efikasb.o mach-pcm037.o mach-bug.c mach-kzm_arm11_01.c mach-mx31lite.o mach-mx53_ard.c mach-pcm038.c mach-bug.o mach-kzm_arm11_01.o mach-mx31moboard.c mach-mx53_ard.o mach-pcm043.c mach-cpuimx27.c mach-mx1ads.c mach-mx31moboard.o mach-mx53_evk.c mach-pcm043.o mach-cpuimx35.c mach-mx21ads.c mach-mx35_3ds.c mach-mx53_evk.o mach-qong.c mach-cpuimx51.c mach-mx25_3ds.c mach-mx35_3ds.o mach-mx53_loco.c mach-qong.o mach-cpuimx51.o mach-mx27_3ds.c mach-mx50_rdp.c mach-mx53_loco.o mach-scb9328.c mach-cpuimx51sd.c mach-mx27ads.c mach-mx51_3ds.c mach-mx53_smd.c mach-vpr200.c mach-cpuimx51sd.o mach-mx31_3ds.c mach-mx51_3ds.o mach-mx53_smd.o mach-vpr200.o mach-eukrea_cpuimx25.c mach-mx31_3ds.o mach-mx51_babbage.c mach-mxt_td60.c mach-imx27ipcam.c mach-mx31ads.c mach-mx51_babbage.o mach-pca100.c mach-imx27lite.c mach-mx31ads.o mach-mx51_efikamx.c mach-pcm037.c Some of them i'm not familiar and i don't know whether they may use pinctrl so i just patched the affected ones. One lazy method may be just patch all board files without pinctrl support and it will not cause any error. What's your suggestion? > pinctrl. Let's add the provide_dummies call to the SoCs instead which > do not have pinctrl yet. > You meant add provide_dummies call in imx*_soc_init call? We could do it but there might be a case that some boards are converted to use pinctrl while others still not but they're based on the same soc. For examples, 4 mx53 boards and we may not be able to convert them all at the same time. Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists