linux-kernel - Re: [PATCH] IPVS: ip_vs_sync.c: local functions should not be exposed globally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120427005713.GC5105@verge.net.au>
Date:	Fri, 27 Apr 2012 09:57:13 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Julian Anastasov <ja@....bg>
Cc:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] IPVS: ip_vs_sync.c: local functions should not be
 exposed globally

On Thu, Apr 26, 2012 at 11:11:54PM +0300, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Thu, 26 Apr 2012, H Hartley Sweeten wrote:
> 
> > Functions not referenced outside of a source file should be marked
> > static to prevent it from being exposed globally.
> > 
> > This quiets the sparse warnings:
> > 
> > warning: symbol 'ip_vs_sync_conn_v0' was not declared. Should it be static?
> > 
> > Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > 
> > ---
> > 
> > diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> > index bf5e538..49a1fe8 100644
> > --- a/net/netfilter/ipvs/ip_vs_sync.c
> > +++ b/net/netfilter/ipvs/ip_vs_sync.c
> > @@ -446,7 +446,7 @@ ip_vs_sync_buff_create_v0(struct netns_ipvs *ipvs)
> >   *      Version 0 , could be switched in by sys_ctl.
> >   *      Add an ip_vs_conn information into the current sync_buff.
> >   */
> > -void ip_vs_sync_conn_v0(struct net *net, struct ip_vs_conn *cp)
> > +static void ip_vs_sync_conn_v0(struct net *net, struct ip_vs_conn *cp)
> 
> 	The 3 patches for IPVS look correct but this change
> is already not needed after one of our planned changes:
> 
> "ipvs: reduce sync rate with time thresholds"
> 
> 	Not sure how we will avoid the collision, may be
> Simon will take only the other 2 changes? Or David will
> take all changes and we have to rebase?

I think the best way forwards is for me to take only the first two changes.

I don't think that this fix is 3.4 material and as you say we expect this
problem to be resolved by other means in 3.5.

I am of course open to discussion on this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/