linux-kernel - Re: Default Kconfig state for hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120427123626.GH18260@opensource.wolfsonmicro.com>
Date:	Fri, 27 Apr 2012 13:36:26 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
	balbi@...com, Herbert Xu <herbert@...dor.apana.org.au>,
	Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org
Subject: Re: Default Kconfig state for hw_random drivers

On Fri, Apr 27, 2012 at 02:31:36PM +0200, Nicolas Ferre wrote:

> I had the same kind of discussion with Felipe and Arnd in this thread:
> http://thread.gmane.org/gmane.linux.ports.arm.kernel/122248/focus=122304

> The conclusion came out after Arnd's strong arguments:
> http://article.gmane.org/gmane.linux.ports.arm.kernel/122962

> Maybe adding a "default" directive can be an valid option?

There is one, that's the problem - the driver is defaulting to the same
state as the main hw_random option (as is idiomatic for this subsystem).
This means that if you've enabled any hw_random device this driver will
be enabled by default.  I would argue that this default directive only
makes sense if there's an explicit dependency limiting the platforms it
can build on.  If it can build on any platform then omitting the default
and just defaulting to N as is normal for drivers would be better.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)