linux-kernel - Re: [PATCH 06/12] perf/x86-ibs: Precise event sampling with IBS for AMD CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBTLODTnWQkdiysRnnThrz1OQweHfMFShgi3bwofestkmg@mail.gmail.com>
Date:	Fri, 27 Apr 2012 17:57:09 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Robert Richter <robert.richter@....com>,
	Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/12] perf/x86-ibs: Precise event sampling with IBS for
 AMD CPUs

On Fri, Apr 27, 2012 at 5:30 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Fri, 2012-04-27 at 17:18 +0200, Robert Richter wrote:
>> There is nothing wrong with it. I already implemented that the
>> MISC_EXACT flag is supported. But, the flag is basically not used in
>> the perf tool and there is no modifier or so to only get a precise
>> rip.
>
> Just because userspace doesn't dtrt doesnt mean its a good idea to wreck
> the kernel side of things.
>
> Instead fix the userspace.
>
I was going to suggest you add an option to perf annotate/report to filter out
non exact_ip samples. That can't be that hard to do.


> I'll simply not take patches that silently drops samples.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/