linux-kernel - Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120427.150849.187285510481819228.davem@davemloft.net>
Date:	Fri, 27 Apr 2012 15:08:49 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	torvalds@...ux-foundation.org
Cc:	mjt@....msk.ru, linux-kernel@...r.kernel.org,
	autofs@...r.kernel.org, raven@...maw.net, thomas@...3r.de,
	stable@...nel.org
Subject: Re: [PATCH v2] Introduce a version6 of autofs interface, to fix
 design error.

From: Linus Torvalds <torvalds@...ux-foundation.org>
Date: Fri, 27 Apr 2012 11:42:58 -0700

> On Fri, Apr 27, 2012 at 11:34 AM, David Miller <davem@...emloft.net> wrote:
>>
>> If systemd wants to use version 5 of this thing, it has to have the
>> same workaround code automountd has.  It is systemd (and now the
>> kernel) which is broken.
> 
> There's no question that systemd is broken.
> 
> But those broken binaries are out in the wild. End of story.

And my point is that automountd was out there longer, and encoded
the "broken" structure size into the resulting binaries.

>> We should have never touched version 5 of the data-structure.  Having
>> 5 years of workaround precedence in userspace proves this.
> 
> Umm. The thing is, those broken binaries *work* on 32-bit.  They were
> *tested* on 32-bit. They were *shipped* on 32-bit.

As were the automount binaries.

systemd coded to an interface which did not exist in reality, and if
they had used the automountd sources as a reference (the only other
user of this interface) they would have seen this.

Look, I can almost guarantee that whoever wrote the automountd
workaround code looked at this situation and said "yeah, it's
impossible to get this right in the kernel for all cases for v5, so
let's just do it where we _can_ be absolutely certain and that's here
in this userland routine doing the autofs stuff"

And you know what, whoever that guy was, he was right.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/