linux-kernel - [PATCH v2] x86,nmi: Fix the type of nmiaction.flags field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1335559255-13454-1-git-send-email-betty.dall@hp.com>
Date:	Fri, 27 Apr 2012 14:40:55 -0600
From:	Betty Dall <betty.dall@...com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Cc:	Don Zickus <dzickus@...hat.com>, linux-kernel@...r.kernel.org,
	Betty Dall <betty.dall@...com>
Subject: [PATCH v2] x86,nmi: Fix the type of nmiaction.flags field

This patch changes the type of the struct nmiaction flags field to
unsigned long from unsigned int. All the usages of the flags field
are unsigned long already. There is only one flag used currently,
NMI_FLAG_FIRST, but having the wrong size could cause a truncation
bug in the future on 64 bit architectures.

v1->v2: The structure moved from nmi.c to nmi.h in the tip git tree
so I am anticipating a merge conflict with the first patch sent by
Don Zickus.

Signed-off-by: Betty Dall <betty.dall@...com>
Signed-off-by: Don Zickus <dzickus@...hat.com>
---
 arch/x86/include/asm/nmi.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/nmi.h b/arch/x86/include/asm/nmi.h
index a1a836c..0e3793b 100644
--- a/arch/x86/include/asm/nmi.h
+++ b/arch/x86/include/asm/nmi.h
@@ -40,7 +40,7 @@ typedef int (*nmi_handler_t)(unsigned int, struct pt_regs *);
 struct nmiaction {
 	struct list_head	list;
 	nmi_handler_t		handler;
-	unsigned int		flags;
+	unsigned long		flags;
 	const char		*name;
 };
 
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/