linux-kernel - Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F9B055E.6030404@zytor.com>
Date:	Fri, 27 Apr 2012 13:45:18 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	David Miller <davem@...emloft.net>
CC:	torvalds@...ux-foundation.org, mjt@....msk.ru,
	linux-kernel@...r.kernel.org, autofs@...r.kernel.org,
	raven@...maw.net, thomas@...3r.de, stable@...nel.org
Subject: Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design
 error.

On 04/27/2012 12:08 PM, David Miller wrote:
>>
>> Umm. The thing is, those broken binaries *work* on 32-bit.  They were
>> *tested* on 32-bit. They were *shipped* on 32-bit.
> 
> As were the automount binaries.
> 
> systemd coded to an interface which did not exist in reality, and if
> they had used the automountd sources as a reference (the only other
> user of this interface) they would have seen this.
> 
> Look, I can almost guarantee that whoever wrote the automountd
> workaround code looked at this situation and said "yeah, it's
> impossible to get this right in the kernel for all cases for v5, so
> let's just do it where we _can_ be absolutely certain and that's here
> in this userland routine doing the autofs stuff"
> 
> And you know what, whoever that guy was, he was right.

The workaround in automount is a mistake too, though.  The better
solution would have been to swallow the extra zero field; data driven.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/