[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120428133826.GL27997@infradead.org>
Date: Sat, 28 Apr 2012 10:38:26 -0300
From: Arnaldo Carvalho de Melo <acme@...radead.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
David Ahern <dsahern@...il.com>,
Frederic Weisbecker <fweisbec@...il.com>,
Hagen Paul Pfeifer <hagen@...u.net>,
Mike Galbraith <efault@....de>,
Namhyung Kim <namhyung@...il.com>,
Paul Mackerras <paulus@...ba.org>,
Peter Zijlstra <peterz@...radead.org>,
Stephane Eranian <eranian@...gle.com>
Subject: Re: [GIT PULL 0/4] perf/annotate loop detection V2, fixes
Em Fri, Apr 27, 2012 at 04:17:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Apr 27, 2012 at 11:23:24AM -0700, Linus Torvalds escreveu:
> > On Fri, Apr 27, 2012 at 11:03 AM, Arnaldo Carvalho de Melo
> > > I should have reworded the "loop detection" with "basic jump arrows" in
> > > the first place.
> >
> > .. and that is fine. But then you need to do it for *forwards* jumps
> > too. There is no difference between backwards and forwards jumps
> > *unless* you are looking for loops, and if you are looking for loops
> > you need to actually find the cycle.
>
> Ok, so I changed things to not try to detect loops at all, for now, and
> instead just start with 'show jumps' on, hotkey 'j', that will draw
> arrows from jumps to its targets, backwards or forwards, when the cursor
> is on a jump instruction, take a look:
I pushed this one plus some more changes to my perf/annotate branch.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists