linux-kernel - Re: [PATCH 2/2] mm: memblock - Handled failure of debug fs entries creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20120428120657.4982a248.akpm@linux-foundation.org>
Date:	Sat, 28 Apr 2012 12:06:57 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Sasikanth babu <sasikanth.v19@...il.com>
Cc:	Tejun Heo <tj@...nel.org>, "H. Peter Anvin" <hpa@...ux.intel.com>,
	Ingo Molnar <mingo@...e.hu>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: memblock - Handled failure of debug fs entries
 creation

On Sun, 29 Apr 2012 00:32:26 +0530 Sasikanth babu <sasikanth.v19@...il.com> wrote:

> > Fact is, debugfs_create_dir() and debugfs_create_file() are stupid
> > interfaces which don't provide the caller (and hence the user) with any
> > information about why they failed.  Perhaps memblock_init_debugfs()
> > should return -EWESUCK.
> >
> 
>    I'm working on a patch which address this issue. debugfs_create_XXX
> calls
>    will return proper error codes, and fixing the existing code not each
> and every part  but the code
>    which handles the values returned by debufs_create_XXX otherwise it will
> break the existing
>    functionality .

Excellent!

> (any suggestions or opinions ?)

Well, don't modify the existing interfaces: create new ones and we can
migrate gradually.  But you're probably already doing that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/