linux-kernel - Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F9D9C4C.7000904@msgid.tls.msk.ru>
Date:	Sun, 29 Apr 2012 23:53:48 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Thomas Meyer <thomas@...3r.de>,
	David Miller <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, autofs@...r.kernel.org,
	raven@...maw.net, stable@...nel.org
Subject: Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design
 error.

On 29.04.2012 23:09, Linus Torvalds wrote:
> 
> This keeps Alan's idea of using O_DIRECT, but only makes it matter for
> the writer - because now the "packet" thing is a per-pipe-buffer state
> (we already had per-pipe-buffer flags, so this is not anything new).
> So when you *write* using a O_DIRECT pipe, it will create packetized
> buffers, and the reader just sees that directly.
> 
> So this should "just work", and doesn't need any extra flags in the
> pipe_inode_info. And the user space interface remains the same: you
> can create these packet pipes with "pipe2(fd, O_DIRECT)" if you want
> to, and my test-program gives exactly the same output.

Ok.  I verified this on 3.3 kernel (with the original fix reverted),
and now both autofs5 and systemd works.

I also verified it on 3.0 kernel (3.0.30), the patch also applies
there just fine (with 1..2 lines offsets) and works too -- at least
on 32/64 bits.

So, the result appears to be an excellent solution to a bad problem...

Thank you all for the efforts and support!

You can add my

Tested-off-by: Michael Tokarev <mjt@....msk.ru>

(I'd add a Signed-off-by, but it is not my patch ;)

/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/