linux-kernel - Re: [PATCH 01/02] fixed coding style issue with comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120429145907.GB3536@andi>
Date:	Sun, 29 Apr 2012 16:59:07 +0200
From:	Andi Shyti <andi.shyti@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/02] fixed coding style issue with comments

Hi,

On Sun, Apr 29, 2012 at 06:50:14PM +0530, Jeffrin Jose wrote:
> Fixed coding style issue relating to comments

[...]

>  	if (crate != rate) {
>  		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
> -		// runtime->rate = crate;
> +		/* runtime->rate = crate; */
>  	}


If you really want ti fix some style issues, you could also split
the snd_printd() line that is over 80 characters.
Moreover, this comment is not really meaningful, I would remove
it at all.

I would prefer something like

-	if (create != rate) {
+	if (create != rate)
-		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
+		snd_printd(KERN_WARNING
+			"current rate %d is different from runtime rate %d\n",
+			crate, rate);
-		// runtime->rate = crate;
-  	}

Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/