linux-kernel - Re: [PATCH 0/3] hid: Enable report fixup on rebind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1204301405260.1856@pobox.suse.cz>
Date:	Mon, 30 Apr 2012 14:06:57 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Nikolai Kondrashov <spbnick@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] hid: Enable report fixup on rebind

On Mon, 30 Apr 2012, Henrik Rydberg wrote:

> > Regarding the code, could it be the time to fix naming of report
> > descriptor-handling functions to improve distinction from report-handling
> > ones? I'm attaching a patch applying on top of Henrik's changes which should
> > illustrate the proposal.
> 
> The changes you propose force changes to out-of-tree-drivers, without
> any obvious benefit. 

I agree that *_parse_rdesc() would be much better than *_parse_report() 
(we have been having this slight misnomer in the HID code since ever).

I wouldn't care too much about out-of-tree drivers, they have to adapt 
gradually to our random HID API changes anyway.

Thanks to both of you,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/