linux-kernel - Re: [PATCH] staging/iio/meter: fix the coding style problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120430200444.GM6447@mwanda>
Date:	Mon, 30 Apr 2012 23:04:44 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	joseph daniel <josephdanielwalter@...il.com>
Cc:	Jonathan Cameron <jic23@....ac.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/iio/meter: fix the coding style problem

On Tue, May 01, 2012 at 01:26:17AM +0600, joseph daniel wrote:
> 
> Signed-off-by: joseph daniel <josephdanielwalter@...il.com>
> ---
> Hi Lars,
> 	Thanks for review. how about the below change?

Slow down.  There is no rush.  It's better to sit on patches
overnight so you can review them carefully the next day.  Take the
time to write a proper changelog...

>  drivers/staging/iio/meter/ade7854-i2c.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 1e1faa0..52bdb05 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -181,6 +181,7 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
>  {
>  	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>  	struct ade7854_state *st = iio_priv(indio_dev);
> +	uint32_t value;

Use the endian notation here:

	__be32 value;

http://lwn.net/Articles/205624/

The rest looks fine to me.  Package it up like a proper patch and
resend.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/