linux-kernel - Re: [RFC PATCH] namespaces: fix leak on fork() failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1335756337.17899.9.camel@marge.simpson.net>
Date:	Mon, 30 Apr 2012 05:25:37 +0200
From:	Mike Galbraith <efault@....de>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Louis Rilling <louis.rilling@...labs.com>
Subject: Re: [RFC PATCH] namespaces: fix leak on fork() failure

On Sun, 2012-04-29 at 19:59 -0700, Eric W. Biederman wrote: 
> Oleg Nesterov <oleg@...hat.com> writes:

> > Yes, but please note that this change also checks "new == NULL", so I
> > still think the patch is correct.
> 
> Sort of.  It is correct in the sense that it performs magic checks on
> it's arguments to see that it's caller is exit_task_namespaces called
> from the fork failure path.

Yeah, did that to keep namespace fix in namespace source.  Bad idea even
with circles and arrows "hey, I'm an unborn red-headed stepchild".

-Mike



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/