linux-kernel - Re: [PATCH] Regmap: Converts group operation into single read write operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120430222916.GA5604@opensource.wolfsonmicro.com>
Date:	Mon, 30 Apr 2012 23:29:17 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>
Cc:	linux-kernel@...r.kernel.org, Anthony.Olech@...semi.com
Subject: Re: [PATCH] Regmap: Converts group operation into single read write
 operations

On Mon, Apr 30, 2012 at 12:05:46PM +0530, Ashish Jangam wrote:
> Some devices does not support bulk read and write operations, for them
> we have series of single write and read operations.

Applied, though please in future

 - Use a changelog that matches the subsystem
 - Follow the kernel coding style, you should use

I fixed both these things up, and also...

> +	if (config->use_single_rw)
> +		map->use_single_rw = config->use_single_rw;

There's no need to check if the flag is set here, you can just assign
directly.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)