linux-kernel - Re: [PATCH -v11 05/30] PCI: Add busn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQW=BLxjHGKzKQvm15PSyESh+H_rrPkTEZGE-8uWboJWVg@mail.gmail.com>
Date:	Tue, 1 May 2012 00:19:33 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Tony Luck <tony.luck@...el.com>,
	David Miller <davem@...emloft.net>, x86 <x86@...nel.org>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH -v11 05/30] PCI: Add busn_res operation functions

On Mon, Apr 30, 2012 at 5:34 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> On Mon, Apr 30, 2012 at 4:29 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
>> On Sun, Mar 18, 2012 at 11:42 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>>> +void pci_bus_update_busn_res_end(struct pci_bus *b, int bus_max)
>>> +{
>>> +       struct resource *res = &b->busn_res;
>>> +       struct resource old_res = *res;
>>> +
>>> +       res->end = bus_max;
>>
>> I've mentioned before that I'm not comfortable with updating the
>> struct resource after it's been inserted into the tree.  If you want
>> to do an in-place update, I think you need to add a new interface in
>> kernel/resource.c so it can make sure the resource tree remains
>> consistent.
>
> ok, will add one function in kernel/resource.c to make sure that end
> could be updated safely
> by checking parent and children.

Rebased busn_alloc branch and added attached patch into that.

as for removing bus->subordinate and bus->secondary, like to do that later.

Thanks

Yinghai

Download attachment "resource_update.patch" of type "application/octet-stream" (2391 bytes)