linux-kernel - Re: [PATCH] kvm: fix cpuid eax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F9FDD75.4030608@redhat.com>
Date:	Tue, 01 May 2012 15:56:21 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Anthony Liguori <anthony@...emonkey.ws>
CC:	"Michael S. Tsirkin" <mst@...hat.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org, davej@...hat.com
Subject: Re: [PATCH] kvm: fix cpuid eax

On 05/01/2012 03:53 PM, Avi Kivity wrote:
> On 04/30/2012 11:37 PM, Anthony Liguori wrote:
> > On 04/30/2012 09:39 AM, Michael S. Tsirkin wrote:
> >> cpuid eax should return the max leaf so that
> >> guests can find out the valid range.
> >> This matches Xen et al.
> >
> > What KVM does here predates Xen and Hyper-V.
> >
> > This is an ABI breaker.
>
> First, I don't think we ever documented eax, so nothing can rely on it.
>

Actually, we did document it.

However, I think it's safe to change.  The documentation in this case
should say "reserved, returns zero in this implementation", rather than 0.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/