linux-kernel - Re: [PATCH 5/6] mfd/ab8500: support of hierachical interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYec+g8CDrkK1kn6ThQ4a=K9Qye_zbZPgXAei0pDA9Wbw@mail.gmail.com>
Date:	Wed, 2 May 2012 00:18:45 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Samuel Ortiz <sameo@...ux.intel.com>,
	Michel JAOUEN <michel.jaouen@...ricsson.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org,
	Maxime Coquelin <maxime.coquelin@...ricsson.com>
Subject: Re: [PATCH 5/6] mfd/ab8500: support of hierachical interrupt

On Tue, May 1, 2012 at 1:31 PM, Samuel Ortiz <sameo@...ux.intel.com> wrote:

> On Tue, Apr 17, 2012 at 09:30:49AM +0200, Linus Walleij wrote:
>> +static irqreturn_t ab8500_hierarchical_irq(int irq, void *dev)
>> +{

>> +     /*  Hierarchical interrupt version */
>> +     for (i = 0; i < AB8500_IT_LATCHHIER_NUM; i++) {
>> +             do {
>> +                     int latch_bit = __ffs(hier_val);
>> +                     do {
>> +                             int int_bit = __ffs(latch_val);
>> +                     } while (latch_val);
>> +             } while (hier_val);
>> +     }
>> +     return IRQ_HANDLED;
>> +}
>
> With 4 nested loops, this one is getting difficult to read. Have you
> considered splitting the loops into separate routines ?

I get the point :-D

Michel do you think this can be done?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/