linux-kernel - Re: [PATCH] debugfs: New debugfs interface for creation of files, directory and symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 May 2012 08:31:00 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sasikantha babu <sasikanth.v19@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] debugfs: New debugfs interface for creation of files,
 directory and symlinks

On Wed, May 02, 2012 at 06:20:54PM +0530, Sasikantha babu wrote:
> As we know the current debugfs file or directory or symlink creation
> doesn't return proper error codes to the caller on failure. Because 
> of this caller and user could not able to find the exact reason of
> the failure.

And what is the problem with this?  Either the file is created or not,
you really shouldn't care anymore than that.  It's not like you are
going to retry the creation, or are you?

Who really cares if the file is failed to be created?

> As Andrew Morton suggested (http://www.spinics.net/lists/linux-mm/msg33617.html)
> introduced new debugfs interface to create debugfs entries. Newer APIs 
> returns proper error codes(ERR_PTR) on failure.

Again, why?  What root problem are you trying to solve here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/