linux-kernel - checkpatch: brackets around single statements fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 May 2012 11:10:46 -0400
From:	Joe Korty <joe.korty@...r.com>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	joe.korty@...r.com, linux-kernel@...r.kernel.org
Subject: checkpatch: brackets around single statements fix

Checkpatch thinks '#else' is the same as 'else' in its check for
this error:

   WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Joe Korty <joe.korty@...r.com>

Index: linux/scripts/checkpatch.pl
===================================================================
--- linux.orig/scripts/checkpatch.pl	2012-04-17 05:00:37.000000000 -0400
+++ linux/scripts/checkpatch.pl	2012-05-02 10:29:03.000000000 -0400
@@ -3038,7 +3038,7 @@
 			}
 		}
 		if (!defined $suppress_ifbraces{$linenr - 1} &&
-					$line =~ /\b(if|while|for|else)\b/) {
+					$line =~ /[^#]\b(if|while|for|else)\b/) {
 			my $allowed = 0;
 
 			# Check the pre-context.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/