linux-kernel - Re: [PATCH] Cleanup page-type.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FA17A95.9050603@gmail.com>
Date:	Wed, 02 May 2012 14:19:01 -0400
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Ulrich Drepper <drepper@...adia.org>
CC:	akpm@...ux-foundation.org, dyoung@...hat.com,
	fengguang.wu@...el.com, kosaki.motohiro@...fujitsu.com,
	linux-kernel@...r.kernel.org, n-horiguchi@...jp.nec.com,
	kosaki.motohiro@...il.com
Subject: Re: [PATCH] Cleanup page-type.c

(5/2/12 10:41 AM), Ulrich Drepper wrote:
> Compiling page-type.c with a recent compiler produces many warnings,
> mostly related to signed/unsigned comparisons.  This patch cleans up
> most of them.
> 
> One remaining warning is about an unused parameter.  The<compiler.h>
> file doesn't define a __unused macro (or the like) yet.  This can be
> addressed later.
> 
> The line numbers for this patch correspond to the file changed to remove
> the duplicate definitions of the KPF_* macros which is contained in
> another patch.  It should apply cleanly albeit with warnings even without
> that patch applied first.
> 
> 
> Signed-off-by: Ulrich Drepper<drepper@...il.com>
> 
>   page-types.c |   22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)

Looks good to me.
 Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>


offtopic:
Wu, I have (unrelated) one question. page-type is used from production
systems nowadays. Why don't you want to move page-type.c into tools/ dir?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/