linux-kernel - staging/rtl8712: unhandled default case in SwLedOn function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFDqYy3OCmRHFR05=iQs-Q1hc5OMwZFiVkDbVnv5KXPA5pxfQA@mail.gmail.com>
Date:	Thu, 3 May 2012 02:10:17 +0600
From:	joseph daniel <josephdanielwalter@...il.com>
To:	Larry Finger <Larry.Finger@...inger.net>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ali Bahar <ali@...ernetDog.org>, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: staging/rtl8712: unhandled default case in SwLedOn function.

Hi kernel developers,

In the function SwLedOn in rtl8712_led.c, we put the bLedOn = true,
even if its a default case. may be we need to return? or BUG()?.

the code listing is:

if ((padapter->bSurpriseRemoved == true) ||
        (padapter->bDriverStopped == true))
        return;
    LedCfg = r8712_read8(padapter, LEDCFG);
    switch (pLed->LedPin) {
    case LED_PIN_GPIO0:
        break;
    case LED_PIN_LED0:
        /* SW control led0 on.*/
        r8712_write8(padapter, LEDCFG, LedCfg&0xf0);
        break;
    case LED_PIN_LED1:
        /* SW control led1 on.*/
        r8712_write8(padapter, LEDCFG, LedCfg&0x0f);
        break;
    default:
        break;
    }
    pLed->bLedOn = true;

Thanks,
Dev.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/