linux-kernel - Re: [PATCH v3 0/2] SUNRPC: separate per-net data creation from service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120502215837.GA12089@fieldses.org>
Date:	Wed, 2 May 2012 17:58:37 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Stanislav Kinsbursky <skinsbursky@...allels.com>
Cc:	Trond.Myklebust@...app.com, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH v3 0/2] SUNRPC: separate per-net data creation from
 service

Thanks, applying.

--b.

On Wed, May 02, 2012 at 04:08:29PM +0400, Stanislav Kinsbursky wrote:
> creation
> 
> v3: "SUNRPC: new svc_bind() routine introduced" patch was squashed with the
>     "SUNRPC: check rpcbind clients usage counter before decrement" patch.
> 
> v2: Increase per-net usage counted in lockd_up_net().
> 
> This is a cleanup patch set.
> It will be followed my LockD start/stop cleanup patch set and NFS callback
> service containerization patch set (yes, I forgot to implement it).
> 
> Today per-net data is created with service, and then is service is starting in
> other network namespace. And thus it's destroyed with service too. Moreover,
> network context for destroying of per-net data is taken from current process.
> This is correct, but code looks ugly.
> This patch set separates per-net data allocation from service allocation and
> destruction.
> IOW, per-net data have to be destroyed by service users - not service itself.
> 
> BTW, NFSd code become uglier with this patch set. Sorry.
> But I assume, that these new ugly parts will be replaced later by NFSd service
> containerization code.
> 
> The following series implements...
> 
> ---
> 
> Stanislav Kinsbursky (2):
>       SUNRPC: new svc_bind() routine introduced
>       SUNRPC: move per-net operations from svc_destroy()
> 
> 
>  fs/lockd/svc.c             |   33 +++++++++++++++++++++------------
>  fs/nfs/callback.c          |   11 +++++++++++
>  fs/nfsd/nfsctl.c           |    4 ++++
>  fs/nfsd/nfssvc.c           |   16 ++++++++++++++++
>  include/linux/sunrpc/svc.h |    1 +
>  net/sunrpc/rpcb_clnt.c     |   12 +++++++-----
>  net/sunrpc/svc.c           |   23 ++++++++++-------------
>  7 files changed, 70 insertions(+), 30 deletions(-)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/