linux-kernel - re: params: add 3rd arg to option handler callback signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120503083809.GA15622@elgon.mountain>
Date:	Thu, 3 May 2012 11:38:17 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	jim.cromie@...il.com
Cc:	linux-kernel@...r.kernel.org
Subject: re: params: add 3rd arg to option handler callback signature

Hello Jim Cromie,

This is a semi-automatic email about new static checker warnings in
linux-next.

The patch 9fb48c744ba6: "params: add 3rd arg to option handler
callback signature" from Apr 27, 2012, leads to the following Smatch
complaint:

kernel/params.c:196 parse_args()
	 error: we previously assumed 'args' could be null (see line 193)

kernel/params.c
   192	
   193		if (args && *args)
                    ^^^^
New check.

   194			pr_debug("doing %s, parsing ARGS: '%s'\n", doing, args);
   195	
   196		while (*args) {
                       ^^^^^
Old dereference.

   197			int ret;
   198			int irq_was_disabled;

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/