linux-kernel - Re: [PATCH v5] ARM: cache-l2x0.c: save the final aux ctrl value for resuming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FA28200.7020508@marvell.com>
Date:	Thu, 3 May 2012 21:02:56 +0800
From:	Yilu Mao <ylmao@...vell.com>
To:	Catalin Marinas <catalin.marinas@....com>
CC:	Lu Mao <ylmao@...vell.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"Baohua.Song@....com" <Baohua.Song@....com>,
	"santosh.shilimkar@...com" <santosh.shilimkar@...com>,
	"robherring2@...il.com" <robherring2@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5] ARM: cache-l2x0.c: save the final aux ctrl value for
 resuming

On 05/03/2012 08:59 PM, Catalin Marinas wrote:
> On Thu, May 03, 2012 at 01:07:37PM +0100, Yilu Mao wrote:
>> There is a bug if l2x0 controller has been enabled when calling
>> l2x0_init, the aux ctrl register will not be saved in l2x0_saved_regs.
>> Therefore we will use uninitialized l2x0_saved_regs.aux_ctrl for
>> resuming later.
>>
>> In this patch, the aux ctrl value is read and saved after it is
>> initialized. So we have the real value being set for resuming.
>>
>> Signed-off-by: Yilu Mao<ylmao@...vell.com>
>
> Acked-by: Catalin Marinas<catalin.marinas@....com>
Hi Catalin,

Thanks for reviewing.
I have another question:
There are a lot of registers in l2x0 controller.
Why we only save so small amount of registers?
Base on l2x0 spec, they suggest to save/restore all of them.

-- 
Thanks.

Best Wishes,
Yilu Mao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/