lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 May 2012 14:20:05 +0100 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Peter Ujfalusi <peter.ujfalusi@...com> Cc: Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org, Misael Lopez Cruz <misael.lopez@...com>, Benoit Cousson <b-cousson@...com>, devicetree-discuss@...ts.ozlabs.org, Liam Girdwood <lrg@...com> Subject: Re: [PATCH 2/3] MFD: twl6040: Allocate IRQ numbers dynamically On Thu, May 03, 2012 at 03:54:24PM +0300, Peter Ujfalusi wrote: > /* In order to operate correctly we need valid interrupt config */ > - if (!client->irq || !pdata->irq_base) { > + if (!client->irq) { It looks like you're totally removing the use of irq_base which will break any boards that didn't convert to DT. The usual idiom is to use irq_base as the base for the range of requested IRQs if it's supplied, otherwise set it to -1 to allow dynamic allocation. This should keep existing users working without disruption. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists