linux-kernel - Re: [PATCH] fs/reiserfs/journal.c: add missing brelse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 03 May 2012 16:45:20 +0200
From:	Edward Shishkin <edward.shishkin@...il.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
CC:	reiserfs-devel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/reiserfs/journal.c: add missing brelse

On 05/03/2012 04:12 PM, Julia Lawall wrote:
> From: Julia Lawall<Julia.Lawall@...6.fr>
>
> Brelse is called to put bhjh on every way out of the function except this one.

Yes, thanks.
Acked-by: Edward Shishkin <edward.shishkin@...il.com>

>
> Signed-off-by: Julia Lawall<Julia.Lawall@...6.fr>
>
> ---
>   fs/reiserfs/journal.c |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index b1a0857..1ef9cbc 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -2757,8 +2757,10 @@ int journal_init(struct super_block *sb, const char *j_dev_name,
>   	    le32_to_cpu(jh->jh_journal.jp_journal_max_commit_age);
>   	journal->j_max_trans_age = JOURNAL_MAX_TRANS_AGE;
>
> -	if (check_advise_trans_params(sb, journal) != 0)
> +	if (check_advise_trans_params(sb, journal) != 0) {
> +		brelse(bhjh);
>   	        goto free_and_return;
> +	}
>   	journal->j_default_max_commit_age = journal->j_max_commit_age;
>
>   	if (commit_max_age != 0) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/