linux-kernel - Re: [PATCH 3/4] zsmalloc use zs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FA2A2F0.3030509@linux.vnet.ibm.com>
Date:	Thu, 03 May 2012 10:23:28 -0500
From:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
To:	Nitin Gupta <ngupta@...are.org>
CC:	Minchan Kim <minchan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH 3/4] zsmalloc use zs_handle instead of void *

On 05/03/2012 08:32 AM, Nitin Gupta wrote:

> On 5/3/12 2:40 AM, Minchan Kim wrote:
>> We should use zs_handle instead of void * to avoid any
>> confusion. Without this, users may just treat zs_malloc return value as
>> a pointer and try to deference it.
>>
>> Cc: Dan Magenheimer<dan.magenheimer@...cle.com>
>> Cc: Konrad Rzeszutek Wilk<konrad.wilk@...cle.com>
>> Signed-off-by: Minchan Kim<minchan@...nel.org>
>> ---
>>   drivers/staging/zcache/zcache-main.c     |    8 ++++----
>>   drivers/staging/zram/zram_drv.c          |    8 ++++----
>>   drivers/staging/zram/zram_drv.h          |    2 +-
>>   drivers/staging/zsmalloc/zsmalloc-main.c |   28
>> ++++++++++++++--------------
>>   drivers/staging/zsmalloc/zsmalloc.h      |   15 +++++++++++----
>>   5 files changed, 34 insertions(+), 27 deletions(-)
> 
> This was a long pending change. Thanks!


The reason I hadn't done it before is that it introduces a checkpatch
warning:

WARNING: do not add new typedefs
#303: FILE: drivers/staging/zsmalloc/zsmalloc.h:19:
+typedef void * zs_handle;

In addition this particular patch has a checkpatch error:

ERROR: "foo * bar" should be "foo *bar"
#303: FILE: drivers/staging/zsmalloc/zsmalloc.h:19:
+typedef void * zs_handle;

--
Seth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/