linux-kernel - Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1336017507.13866.2.camel@joe2Laptop>
Date:	Wed, 02 May 2012 20:58:27 -0700
From:	Joe Perches <joe@...ches.com>
To:	Eric Nelson <eric.nelson@...ndarydevices.com>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	u-boot@...ts.denx.de, rylv50@...escale.com, marex@...x.de,
	vapier@...too.org
Subject: Re: [PATCH] checkpatch: add check for whitespace before semicolon
 at end-of-line

On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
> This tests for a bad habits of mine like this:
> 
> 	return 0 ;
> 
> Signed-off-by: Eric Nelson <eric.nelson@...ndarydevices.com>
> ---
>  scripts/checkpatch.pl |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a3b9782..0e6977e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3227,6 +3227,12 @@ sub process {
>  			 "Statements terminations use 1 semicolon\n" . $herecurr);
>  		}
>  
> +# check for whitespace before semicolon - not allowed at end-of-line
> +		if ($line =~ /\s+;$/) {

		if ($line =~ /\s+;\s*$/)

> +		    WARN("SPACEBEFORE_SEMICOLON",

		    WARN("SPACING",
	
> +			 "Whitespace before semicolon\n" . $herecurr);
> +		}
> +


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/