linux-kernel - Re: [PATCH 09/13] perf target: Introduce perf_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FA2EF67.9070107@gmail.com>
Date:	Thu, 03 May 2012 14:49:43 -0600
From:	David Ahern <dsahern@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
CC:	Namhyung Kim <namhyung.kim@....com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/13] perf target: Introduce perf_target_errno

On 5/3/12 2:42 PM, Arnaldo Carvalho de Melo wrote:
> Em Thu, May 03, 2012 at 02:34:20PM -0600, David Ahern escreveu:
>> On 5/2/12 12:59 PM, Arnaldo Carvalho de Melo wrote:
>>> Also it would be better to have it as PERF_ERRNO__PID_OVERRIDE_CPU, etc.
>>
>> I thought you wanted subsystem based errno's (PERF_TARGET__XXXXX)
>> versus one big set (PERF_ERRNO__XXXXX). Did you change your mind?
>
> Oops, I didn't realize PID being the subsys, then yeah, that is ok.
>
> But that would make it PERF_ERR__TARGET_, as PERF_TARGET__ doesn't
> straight away brings back "error enumeration", at least for me :)
>
> But this is getting overly long, ideas?
>
> PERF_ we need, its libperf's "namespace", then ERRNO looks needed too,
> heck, make it long:
>
> PERF_ERRNO_TARGET__PID_OVERRIDE_CPU
>
> After all most of the time this will just be inside the function setting
> the error and the strerrno function that will convert this to an string,
> right?

Agreed, the long macro name shouldn't be visible outside of the depths 
of the perf files that set it and convert it to a string.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/