linux-kernel - RE: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6436426b-5c46-4457-9d78-6b0af5ce4a3b@default>
Date:	Thu, 3 May 2012 14:11:47 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, Autif Khan <autif.mlist@...il.com>,
	Konrad Wilk <konrad.wilk@...cle.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Robert Jennings <rcj@...ux.vnet.ibm.com>,
	Nitin Gupta <ngupta@...are.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Subject: RE: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency

> From: Randy Dunlap [mailto:rdunlap@...otime.net]
> Sent: Friday, April 27, 2012 6:38 PM
> To: Seth Jennings
> Cc: Greg Kroah-Hartman; devel@...verdev.osuosl.org; Dan Magenheimer; Autif Khan; Konrad Rzeszutek
> Wilk; linux-kernel@...r.kernel.org; linux-mm@...ck.org; Robert Jennings; Nitin Gupta
> Subject: Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
> 
> On 04/23/2012 06:33 PM, Seth Jennings wrote:
> 
> > ZCACHE is a boolean in the Kconfig.  When selected, it
> > should require that CRYPTO be builtin (=y).
> >
> > Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> > when it should not be.
> >
> > This patch changes the zcache Kconfig to enforce this
> > dependency.
> >
> > Signed-off-by: Seth Jennings <sjenning@...ux.vnet.ibm.com>
> 
> 
> Acked-by: Randy Dunlap <rdunlap@...otime.net>

Not sure if you need my approval, but I just in case you are waiting
for it:

Acked-by: Dan Magenheimer <dan.magenheimer@...cle.com>

> > ---
> >  drivers/staging/zcache/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> > index 3ed2c8f..7048e01 100644
> > --- a/drivers/staging/zcache/Kconfig
> > +++ b/drivers/staging/zcache/Kconfig
> > @@ -2,7 +2,7 @@ config ZCACHE
> >  	bool "Dynamic compression of swap pages and clean pagecache pages"
> >  	# X86 dependency is because zsmalloc uses non-portable pte/tlb
> >  	# functions
> > -	depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> > +	depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> >  	select ZSMALLOC
> >  	select CRYPTO_LZO
> >  	default n
> 
> 
> 
> --
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/