linux-kernel - Re: [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+=D-XUBuaT=d=YYou5ZQKM3h9kJcsRM0HCJmLDXfXHZrth0Eg@mail.gmail.com>
Date:	Thu, 3 May 2012 16:39:47 -0700
From:	Michael Davidson <md@...gle.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct
 show/store functions

I found the problem while porting some code to 3.3.

It looks as if the mce driver uses int attributes for a few things so I assume
that is broken but I have not actually verified it.

thanks,

md

On Thu, May 3, 2012 at 4:32 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Thu, May 03, 2012 at 04:19:02PM -0700, Michael Davidson wrote:
>> [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions
>
> This line isn't needed again in the patch body like this :(
>
>> DEVICE_INT_ATTR() should use device_show_int() and device_store_int()
>> not device_show_ulong() and device_store_ulong()
>>
>> Signed-off-by: Michael Davidson <md@...gle.com>
>
> Is this something that fixes a problem you have seen, so it needs to go
> in now, and backported to stable kernel releases, or can it wait for 3.5
> and you found it just by looking at the code?
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/