linux-kernel - [PATCH] video: fb_defio.c: local functions should not be exposed globally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 May 2012 17:23:40 -0700
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>
CC:	<linux-fbdev@...r.kernel.org>, <jayalk@...works.biz>,
	<FlorianSchandinat@....de>
Subject: [PATCH] video: fb_defio.c: local functions should not be exposed globally

Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.

Quiets the sparse warning:

warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
Cc: Jaya Kumar <jayalk@...works.biz>
Cc: Florian Tobias Schandinat <FlorianSchandinat@....de>

---

diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
index 070f26f..1ddeb11 100644
--- a/drivers/video/fb_defio.c
+++ b/drivers/video/fb_defio.c
@@ -23,7 +23,7 @@
 #include <linux/rmap.h>
 #include <linux/pagemap.h>
 
-struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
+static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
 {
 	void *screen_base = (void __force *) info->screen_base;
 	struct page *page;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/