linux-kernel - Re: [PATCH] sched: Enable arch-specific asym packing option in sched domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1336166273.6509.79.camel@twins>
Date:	Fri, 04 May 2012 23:17:53 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Diwakar Tundlam <dtundlam@...dia.com>
Cc:	'Ingo Molnar' <mingo@...nel.org>,
	'Andrew Morton' <akpm@...ux-foundation.org>,
	'Christoph Lameter' <cl@...two.org>,
	'Stephen Rothwell' <sfr@...b.auug.org.au>,
	'Benjamin Herrenschmidt' <benh@...nel.crashing.org>,
	'David Rientjes' <rientjes@...gle.com>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	Michael Neuling <mikey@...ling.org>
Subject: Re: [PATCH] sched: Enable arch-specific asym packing option in
 sched domain

On Fri, 2012-05-04 at 13:28 -0700, Diwakar Tundlam wrote:
> Add arch specific (weak) routine to set (or not set) the ASYM_PACKING
> sched domain flag. This change itself does nothing, but allows archs
> that require asym-packing option to set it by implementing the arch
> specific routine to turn it on.
>     
> The weak symbol is already defined in sched_fair.c but was mis-spelled
> in the header file. Fixed spelling error in the weak symbol definition.
>     
> Change-Id: Ibdf38e0a40f76ee3c1829f08b5feedcf900a1b89

This does not go in a patch..

> Signed-off-by: Diwakar Tundlam <dtundlam@...dia.com>
> ---
>  include/linux/sched.h    |    2 +-
>  include/linux/topology.h |    1 +
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index c569719..cf793f0 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -903,7 +903,7 @@ static inline int sd_balance_for_package_power(void)
>         return SD_PREFER_SIBLING;
>  }
>  
> -extern int __weak arch_sd_sibiling_asym_packing(void);
> +extern int __weak arch_sd_sibling_asym_packing(void);
>  
>  /*
>   * Optimise SD flags for power savings:
> diff --git a/include/linux/topology.h b/include/linux/topology.h
> index b480403..eb09cd4 100644
> --- a/include/linux/topology.h
> +++ b/include/linux/topology.h
> @@ -168,6 +168,7 @@ int arch_update_cpu_topology(void);
>                                 | 0*SD_SHARE_CPUPOWER                   \
>                                 | 0*SD_SHARE_PKG_RESOURCES              \
>                                 | 0*SD_SERIALIZE                        \
> +                               | arch_sd_sibling_asym_packing()        \
>                                 | sd_balance_for_package_power()        \
>                                 | sd_power_saving_flags()               \
>                                 ,                                       \


I think you just wrecked Power7 here..

(also your patch seems white-space challenged)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/