| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1336169378.11505.10.camel@joe2Laptop> Date: Fri, 04 May 2012 15:09:38 -0700 From: Joe Perches <joe@...ches.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: Mauro Carvalho Chehab <mchehab@...radead.org>, "James E.J. Bottomley" <JBottomley@...allels.com>, linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: drivers: Probable misuses of || On Fri, 2012-05-04 at 23:02 +0100, Mark Brown wrote: > On Fri, May 04, 2012 at 02:54:37PM -0700, Joe Perches wrote: > > On Wed, 2012-04-04 at 16:00 -0700, Joe Perches wrote: > > > > drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT) > > > drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT) > > > drivers/media/rc/fintek-cir.c: if ((chip != 0x0408) || (chip != 0x0804)) > > > It's been a month. > > > Do you maintainers not care > > about these obvious defects? > > It'd probably help if you were to supply more analysis as to what the > issues you think you're seeing are - in the cases quoted above > (especially the last one) there's no obvious bug without further > analysis. Likely the || should be &&. if (val != foo || test != bar) is always true when foo != bar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists