linux-kernel - Re: drivers: Probable misuses of ||

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvyAFMtAZYdAggSB-6-0VPvm_RoVXq3p7FFkLRYXLw2ARQ@mail.gmail.com>
Date:	Sat, 5 May 2012 00:45:53 +0200
From:	richard -rw- weinberger <richard.weinberger@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: drivers: Probable misuses of ||

On Thu, Apr 5, 2012 at 1:00 AM, Joe Perches <joe@...ches.com> wrote:
> Likely these should be && not ||
>
> drivers/scsi/FlashPoint.c:                              if(bit_cnt != 0 || bit_cnt != 8)

/*
                                if(bit_cnt != 0 || bit_cnt != 8)
                                {
                                        byte_cnt = 0;
                                        bit_cnt = 0;
                                        FPT_scxferc(p_port, SYNC_PTRN);
                                        FPT_scxferc(p_port, ASSIGN_ID);
                                        continue;
                                }
*/

dead code...

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/