linux-kernel - Re: drivers: Probable misuses of ||

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1336173184.11505.25.camel@joe2Laptop>
Date:	Fri, 04 May 2012 16:13:04 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	richard -rw- weinberger <richard.weinberger@...il.com>
Subject: Re: drivers: Probable misuses of ||

On Fri, 2012-05-04 at 23:56 +0100, Alan Cox wrote:
> On Fri, 04 May 2012 14:54:37 -0700
> Joe Perches <joe@...ches.com> wrote:
> 
> > On Wed, 2012-04-04 at 16:00 -0700, Joe Perches wrote:
> > > Likely these should be && not ||
> > > 
> > > drivers/scsi/FlashPoint.c:				if(bit_cnt != 0 || bit_cnt != 8)
> > 
> > It's been a month.
> > 
> > Do you maintainers not care about these obvious defects?
> 
> You are assuming the code in question has maintainers.

Nope.  I'm assuming the nominal subsystem maintainers
haven't bothered to look at it or are in "don't care"
mode and I am simply prompting people to look again.

Richard Weinberger replied showing that the flashpoint
bit was commented out.  Thanks Richard.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/