linux-kernel - Re: [PATCH] Revert 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 05 May 2012 09:39:38 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Mikulas Patocka <mpatocka@...hat.com>
CC:	Guy Martin <gmsof@...icoman.be>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25

On 05/05/2012 05:04 AM, Mikulas Patocka wrote:
> Hi
> 
> This patch reverts commit 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25.
> 
> The commit 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25 causes system lockup 
> when pdc is used as a boot console.
> 
> The kernel boots, but it locks up when transferring control to userspace 
> --- the message "INIT: version 2.86 booting" is not printed and the 
> computer halts. With the patch reverted, the system starts normally on 
> pdc.
...
> --- a/arch/parisc/kernel/pdc_cons.c
> +++ b/arch/parisc/kernel/pdc_cons.c
...
> @@ -104,10 +103,8 @@ static int pdc_console_tty_open(struct tty_struct *tty, struct file *filp)
>  
>  static void pdc_console_tty_close(struct tty_struct *tty, struct file *filp)
>  {
> -	if (!tty->count) {
> +	if (!tty->count)

Heh, I cannot find a bug in the patch proper. However this test is and
always was bogus. Does changing "!tty->count" to "tty->count == 1" help?

>  		del_timer_sync(&pdc_console_timer);
> -		tty_port_tty_set(&tty_port, NULL);
> -	}
>  }
>  
>  static int pdc_console_tty_write(struct tty_struct *tty, const unsigned char *buf, int count)

regards,
-- 
js
suse labs


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/