linux-kernel - Re: [PATCH 4/4] power-supply: smb347-charger: convert to regmap API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 6 May 2012 09:34:40 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	bruce.e.robertson@...el.com,
	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
Subject: Re: [PATCH 4/4] power-supply: smb347-charger: convert to regmap API

On Sat, May 05, 2012 at 05:52:11AM -0700, Anton Vorontsov wrote:
> 
> I fixed this by the following change:
> 
> diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
> index 1f27d21..cf31b31 100644
> --- a/drivers/power/smb347-charger.c
> +++ b/drivers/power/smb347-charger.c
> @@ -459,7 +459,8 @@ static int smb347_set_voltage_limits(struct smb347_charger *smb)
>  static int smb347_set_temp_limits(struct smb347_charger *smb)
>  {
>  	bool enable_therm_monitor = false;
> -	int ret, val;
> +	int ret = 0;
> +	int val;
>  
>  	if (smb->pdata->chip_temp_threshold) {
>  		val = smb->pdata->chip_temp_threshold;
> 
> Please check if that's all OK.

Looks ok to me. Thanks for fixing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/