linux-kernel - Re: [PATCH 1/8] drivers/staging/line6/control.c: Change strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 06 May 2012 10:27:22 +0200
From:	Johannes Thumshirn <morbidrsa@...glemail.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, stefanha@...il.com,
	andor.daam@...glemail.com, grabner@....tugraz.at, jj@...osbits.net,
	thomas@...3r.de
Subject: Re: [PATCH 1/8] drivers/staging/line6/control.c: Change
 strict_strtoul to kstrtoul

On Sun, 2012-05-06 at 09:34 +0300, Dan Carpenter wrote:
> On Sat, May 05, 2012 at 04:31:45PM +0200, Johannes Thumshirn wrote:
> > Changed strict_strtoul() call to kstrtoul to make checkpatch.pl happy
> > 
> 
> This would probably be better as kstrtou8(). You'd have to change
> the type of value, and the function parameters which take value as
> well.  Also you would have to change the name of pod_set_param_int()
> because it says "int".
> 
> 
> regards,
> dan carpenter
> 

Ok I'll look over these patches again, but I've got another question
regarding these, should I re-diff against the current linux-next or
against these patches?

regards,
Johannes Thumshirn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/