linux-kernel - Re: [PATCH] x86: kernel/microcode_core.c simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120506100314.GB27678@liondog.tnic>
Date:	Sun, 6 May 2012 12:03:14 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Shuah Khan <shuahkhan@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, tglx@...utronix.de,
	tigran@...azian.fsnet.co.uk,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: kernel/microcode_core.c simple_strtoul cleanup

On Sat, May 05, 2012 at 09:37:39AM -0600, Shuah Khan wrote:
> Change reload_for_cpu() in kernel/microcode_core.c to call kstrtoul()
> instead of calling obsoleted simple_strtoul().
> 
> From 8df8b8f87a8e462faa7b4c2b4682b23df5afa4bd Mon Sep 17 00:00:00 2001
> From: Shuah Khan <shuahkhan@...il.com>
> Date: Fri, 4 May 2012 14:12:11 -0600
> Subject: [PATCH] x86: kernel/microcode_core.c simple_strtoul cleanup
> 
> 
> Signed-off-by: Shuah Khan <shuahkhan@...il.com>
> ---
>  arch/x86/kernel/microcode_core.c |    9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c
> index c9bda6d..fbdfc69 100644
> --- a/arch/x86/kernel/microcode_core.c
> +++ b/arch/x86/kernel/microcode_core.c
> @@ -299,12 +299,11 @@ static ssize_t reload_store(struct device *dev,
>  {
>  	unsigned long val;
>  	int cpu = dev->id;
> -	int ret = 0;
> -	char *end;
> +	ssize_t ret = 0;
>  
> -	val = simple_strtoul(buf, &end, 0);
> -	if (end == buf)
> -		return -EINVAL;
> +	ret = kstrtoul(buf, 0, &val);
> +	if (ret)
> +		return ret;
>  
>  	if (val == 1) {
>  		get_online_cpus();
> -- 
> 1.7.9.5

Patch looks correct but your patch format looks all flipped: first you
have the commit message and then the mail headers you get from git
format-patch, what happened? IOW, it should be the other way around.

Go look at other messages on lkml starting with "tip-bot" in the From:
for a proper patch formatting pls.

Thanks.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/