linux-kernel - Re: [RESEND PATCH v2 0/2] power_supply: update Charger-Manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120506025623.GA8437@lizard>
Date:	Sat, 5 May 2012 19:56:23 -0700
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [RESEND PATCH v2 0/2] power_supply: update Charger-Manager

On Tue, Apr 24, 2012 at 07:47:24PM +0900, Chanwoo Choi wrote:
[...]
>  Documentation/power/charger-manager.txt |   41 +++-
>  drivers/power/charger-manager.c         |  391
> +++++++++++++++++++++++++++++++
>  include/linux/power/charger-manager.h   |   49 ++++-
>  3 files changed, 471 insertions(+), 10 deletions(-)

Applied, thanks!

Note that the patches were word-wrap damaged, I had to fix them by
hand. The file 'linux/Documentation/email-clients.txt' contains some
useful tips for setting up commonly used mail clients. You might
also try using 'git send-email'.

While looking through the CM code, I noticed that cm uevents
are not friendly wrt several chargers (the code has static variables
in the uevent_notify() func).

Also, what's the rationale behind implementing own uevent handling,
and not using power_supply uevents (see power_supply_sysfs.c
and power_supply_changed() thing)? Also, you don't seem to
report variables in the uevent, but just messages. That's unusual.

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/