linux-kernel - Re: [PATCH v2 1/3] Staging: IndustryPack bus for the Linux Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 May 2012 10:24:55 +0200
From:	Samuel Iglesias Gonsálvez 
	<siglesias@...lia.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] Staging: IndustryPack bus for the Linux Kernel

On Mon, 2012-05-07 at 11:04 +0300, Dan Carpenter wrote:
> 
> [snip]
> 
> > +int ipack_device_find_drv(struct device_driver *driver, void *param)
> > +{
> > +	int ret;
> > +	struct ipack_device *dev = (struct ipack_device *)param;
> > +
> > +	ret = ipack_bus_match(&dev->dev, driver);
> > +	if (ret)
> > +		return !ipack_bus_probe(&dev->dev);
> 
> Wouldn't probe() return zero or a negative error code?

Yes. However, in case of the function called by bus_for_each_drv(), it
should return zero if you want to continue or nonzero value to stop the
iteration.

I considered that if the probe fails, we can try with the next driver in
the list. So, the returned value of probe() is negated.

I will fix the other things and send it again with other suggestions. 

Thanks,

Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/